FNA Forum Mod Tap

Newbie Joined: Oct 05, 2006 Posts: 15

Well, this was not that hard Smile

Code:

$urlin = array(
'"(?<!/)modules.php\?name=Forums&file=viewtopic&(t|p)=([0-9]*)((\")|(&sid=[a-zA-Z0-9]*))"',
'"(?<!/)modules.php\?name=Forums&file=viewtopic&(t|p)=([0-9]*)#([0-9]*)((\")|(&sid=[a-zA-Z0-9]*))"',
'"(?<!/)modules.php\?name=ForumNews&id=([0-9]*)((\")|(&sid=[a-zA-Z0-9]*))"',
'"(?<!/)modules.php\?name=ForumNews&id=([0-9]*)#([0-9]*)((\")|(&sid=[a-zA-Z0-9]*))"',
'"(?<!/)modules.php\?name=ForumNews&news_id=([0-9]*)((\")|(&sid=[a-zA-Z0-9]*))"',
'"(?<!/)modules.php\?name=ForumNews&news_id=([0-9]*)#([0-9]*)((\")|(&sid=[a-zA-Z0-9]*))"'
);

$urlout = array(
'ftopic\\1-\\2.html\\3',
'ftopic\\1-\\2.html#\\3\\4',
'fnews-\\1.html\\2',
'fnews-\\1.html#\\2\\3',
'fnewstopic-\\1.html\\2',
'fnewstopic-\\1.html#\\2\\3'
);

The part that I do not understand is

Code:

((\")|(&sid=[a-zA-Z0-9]*)

and

#([0-9]*)((\")|(&sid=[a-zA-Z0-9]*))

I never saw this in original links, so this really puzzles me. But it works, though Smile

Site Admin/Owner Joined: Feb 12, 2005 Posts: 1294

That part is due to how the forums pass a "sid" along with the URL. It is for session management. In order for the "tap" to work with the same URL that either has the sid or does not, it needs to have the OR condition in there to pick up both and tap them.

Great job Misha!

Newbie Joined: Oct 05, 2006 Posts: 15

never seen any link with sid, though.
But what I see on my page on Google, its address has &NSNST_Flood=xxx...xxx
I suspect this is sentinel protecting from dos. But I'm wondering, if googlebot is receiving address with NSNST..., would it be converted? This pattern is not coded anywhere Sad

Sorry, if this is a silly question Embarassed

Site Admin/Owner Joined: Feb 12, 2005 Posts: 1294

Unfortunately that is because of NukeSentinel's flood blocker as you have mentioned. There really isn't anything from a "tap" standpoint that you or I can do about that. I don't think it will be an issue. The author of NS needs to get that session off of the GET string.

Newbie Joined: Oct 05, 2006 Posts: 15

Can't we just code it like "sid="?

Site Admin/Owner Joined: Feb 12, 2005 Posts: 1294

I don't think you really want to do that. That would mean having this on each and every urlin array value as an "OR" condition. It would slow down the tapping. Besides, are you using NukeSentinel 2.5.02? You should not be seeing those on the URLs any longer from what I can tell from the code.

Newbie Joined: Oct 05, 2006 Posts: 15

hmm... my version is saying 2.5.1. Isn't this newer than 2.5.02?

Site Admin/Owner Joined: Feb 12, 2005 Posts: 1294

No, the latest is 2.5.02. You are one release level behind (so am I Embarassed

)