HTML Newletter

Newbie Joined: Nov 26, 2007 Posts: 22

Your docs do not say anything about editing the newsletter templates. That is unless I missed it.

They have "&d_op" instead of "&op".

Site Admin/Owner Joined: Feb 12, 2005 Posts: 1294

Ah, all these "tentacles". Good catch. I was holding off cutting a new maintenance release until I got a few more issues. I'll cook up something and I'll post it here as well.

Thanks Palbin!

Site Admin/Owner Joined: Feb 12, 2005 Posts: 1294

Well, that just goes to show you how long its been since I've looked at this. No change is needed for the links to the Downloads vs. NSNGD. It is already handled in admin_make_nls.php with this code here:

Code:

      if ($msnl_gasModCfg['dl_module'] == 'nsngd') {
         $msnl_sRowTmp = str_replace('{DOWNLOAD_OP}', 'd_op', $msnl_sRowTmp);
      } else {
         $msnl_sRowTmp = str_replace('{DOWNLOAD_OP}', 'op', $msnl_sRowTmp);
      }
      $msnl_sRows .= $msnl_sRowTmp;
   }
   $msnl_sLatestDownloads = $latestdownloadtop . $msnl_sRows . $latestdownloadend;}

I should have remembered that as I've used NSN Gr Downloads from the beginning of the HTML Newsletter.

Site Admin/Owner Joined: Feb 12, 2005 Posts: 1294

This gets even more curious. The code posted above seems to be backwards. Isn't the original Downloads module "d_op"? I haven't used the original Downloads module for about 6 years now, so didn't remember that off the top of my head. But, I do see now clearly that NSNGD and now TegoNuke(tm) Downloads does use just "op". Interesting.

It has been working because of this code here in TN/NSNGD:

Code:

if (isset($d_op)) {
$op = $d_op;
unset($d_op);
}

Go figure. So, what I am going to do is change with HNL 1.4 the above IF statement around. I think "op" should be tied to "nsngd". Unfortunately, this will also impact the ShortLinks, so it is going to be awhile before I can get to it. I may also have to provide 301 redirects or just leave both links in (the easiest and not sure "duplicate content" like this is even an issue any longer... its not rampant).