| Author |
Message |
montego
Site Admin/Owner
Joined: Feb 12, 2005
Posts: 1294
|
 Posted:
Thu Mar 16, 2006 9:56 am |
|
| Dawg wrote: |
| No NSN anything. |
Please take a look at your newsletter config settings. If you do not have NSN Groups installed, that checkbox should not be checked. (which I think it was for the output you provided to me because I was able to replicate the exact output stream.
Strange thing is, though, that you should have also gotten a SQL error message at the very bottom as it was trying to pull the NSN Groups. Could you please check your data for a table called: nuke_nsngr_groups.
Thanks. |
_________________
“To err is human, but when the eraser wears out ahead of the pencil, you’re overdoing it.”
-- Josh Jenkins |
|
 
|
|
montego
Site Admin/Owner
Joined: Feb 12, 2005
Posts: 1294
|
| Posted:
Thu Mar 16, 2006 1:06 pm |
|
| Crusader_of_Melnibone wrote: |
Yeah, I guess NSN Groups and everything by NSN is great, and surely it's useful to developers sites, I doubt it'll come in handy to someone like me I guess  Anyway, I've just spent 8 hours integrating a gallery module and my mind's in total chaos, if you'll excuse me 
Btw, Montego, funny you never mentioned it, I just saw a similar problem to mine, actually it sounds exactly the same
http://montegoscripts.com/ftopict-42.html
and it says "resolved". I really need to find out *how*.  |
Ok, there is definitely a problem with the msnl_fFormatDate function for non-English sites. So, what I am going to do is take away the translation feature within 1.3.x and work on a better date formatting routine for 1.4.x. I will finalize the patch and full distro for 1.3.1 -- hopefully today sometime -- and release it. I don't want to wait any longer as the pre 7.5 folks will be having the original problems stated in this topic.
The "fix" I am going to apply is this.
=== OPEN ===
modules/HTML_Newsletter/admin/functions.php:
=== FIND ===
| Code: |
function msnl_fFormatDate( $format, $gmepoch, $tz ) {
global $msnl_asPHPBBCfg, $lang;
static $translate;
if ( empty( $translate ) && $msnl_asPHPBBCfg['default_lang'] != 'english' ) {
@reset( $lang['datetime'] );
while ( list( $match, $replace ) = @each( $lang['datetime'] ) ) {
$translate[$match] = $replace;
}
}
return ( !empty( $translate ) ) ? strtr( @gmdate( $format, $gmepoch + (3600 * $tz) ), $translate ) : @gmdate( $format, $gmepoch + (3600 * $tz) );
} //End of function msnl_fFormatDate() |
=== REPLACE WITH ===
| Code: |
function msnl_fFormatDate( $format, $gmepoch, $tz ) {
global $msnl_asPHPBBCfg, $lang;
static $translate;
/*
if ( empty( $translate ) && $msnl_asPHPBBCfg['default_lang'] != 'english' ) {
@reset( $lang['datetime'] );
while ( list( $match, $replace ) = @each( $lang['datetime'] ) ) {
$translate[$match] = $replace;
}
}
*/
return ( !empty( $translate ) ) ? strtr( @gmdate( $format, $gmepoch + (3600 * $tz) ), $translate ) : @gmdate( $format, $gmepoch + (3600 * $tz) );
} //End of function msnl_fFormatDate() |
Your dates will appear as they do within your forum posts.
Crusaders, I have already deployed this "fix" to your site. Thank you for giving me the access. Since I do not have a non-English site, it makes it difficult to debug these types of issues. You should be fine to create newsletters including Forums and Reviews if you wish.
Now, Dawg, I believe that your issues are not related to this. I think the patch is fine, but if you want me to still take a look at your site, PM me the info that I requested and I'll take a look.
Thanks guys!
Regards,
montego |
_________________
“To err is human, but when the eraser wears out ahead of the pencil, you’re overdoing it.”
-- Josh Jenkins |
|
|
|
|
Dawg
Newbie
Joined: Mar 15, 2006
Posts: 12
|
| Posted:
Sat Mar 18, 2006 10:43 am |
|
Hey Guys....I am going to work on this today around lunch...I will keep you posted...I have been off dealing with Real Life...(I live at the beach and this timeof year it is CRAZY with everyone trying to get ready for the season.}
Thanks for the help!
Dawg |
| |
|
|
|
|
Crusader_of_Melnibone
Newbie
Joined: Mar 10, 2006
Posts: 6
|
| Posted:
Sat Mar 18, 2006 6:02 pm |
|
Thanx Montego for everything! I did not reply any sooner cause I was doing further testing, and today I was able to release my very first official newsletter! 
1. I want you to tell me, if possible, which exact files did you edited (since original version 1.3) so that I can backup them, with the changes I've also made to my convenience
2. I need a way so that the $emailtitle defined is also the $msnl_sTopic I declare in each mail. I tried with several ways, but got a blank page and changed it back, so for now I edit the functions.php manually every time with my preferred title. Can we do it?
3. I did some template testing (especially in the Plain Jane/Grey) and corrected a few things: (a) some wrong links and (b) some width changes; there were times that the width limit was overriden, so I had to define exact pixel sizes for some module info instead of percentages. I know that's not the best thing, but couldn't find another way for the newsletter to keep its boundaries of the tables in the right size. I also noticed that in those templates, (c) there was no review info (that's why it didn't send out anything about that module), so I integrated that one too. With these fixes, I released my new template, Prince Bleu, modifying the css accordingly. I can send it over to you to check it out (maybe also include it in your 'package'  )
Cheers,
Crus |
| |
|
|
|
|
montego
Site Admin/Owner
Joined: Feb 12, 2005
Posts: 1294
|
| Posted:
Sat Mar 18, 2006 6:33 pm |
|
Excellent news Crusader! Thanks for the update. My input is below.
| Crusader_of_Melnibone wrote: |
1. I want you to tell me, if possible, which exact files did you edited (since original version 1.3) so that I can backup them, with the changes I've also made to my convenience |
It would be best to download the 01.03.01 patch and review those files as there are other fixes too that you would want to take advantage. Everything I did on your site is also in the patch, but the patch files may have more fixes. I cannot remember. The patch is a true delta so there are only a handful files to review.
| Quote: |
2. I need a way so that the $emailtitle defined is also the $msnl_sTopic I declare in each mail. I tried with several ways, but got a blank page and changed it back, so for now I edit the functions.php manually every time with my preferred title. Can we do it?
|
I have actually wanted to make that more flexible, but just have not gotten around to incorporating that. I have just added a Sticky here to cover the steps.
http://montegoscripts.com/ftopict-56.html
| Quote: |
3. I did some template testing (especially in the Plain Jane/Grey) and corrected a few things:
|
I have not touched the original templates from the original author of version 1.0. I made Fancy_Content as a part of 1.1 and have only upgraded it as I have added additional capability. The templates were to serve as examples only as I figured that most people would want to create ones to match their needs anyways.
If you like, I can include your revised versions of these in the next release and credit you for the updates. It might make them last longer...
| Quote: |
With these fixes, I released my new template, Prince Bleu, modifying the css accordingly. I can send it over to you to check it out (maybe also include it in your 'package' )
|
Awesome! Great job! Cannot wait to see it. Feel free to send it to me and I will take a look and see if its something I want to include in 1.4. Of course, full credits to you! |
_________________
“To err is human, but when the eraser wears out ahead of the pencil, you’re overdoing it.”
-- Josh Jenkins |
|
|
|
|
Crusader_of_Melnibone
Newbie
Joined: Mar 10, 2006
Posts: 6
|
| Posted:
Sat Mar 18, 2006 8:09 pm |
|
Thanx! Everything sorted out, then! Glad we can all work together for something
I sent you a pm, maybe I'll update the templates in the next few days!
Cheers,
Crus |
| |
|
|
|
|
|
|
![[Valid RSS]](images/valid-rss.png "Validate my RSS feed")
