ShortLinks does not work with nukeSEO SB links

Newbie Joined: Sep 05, 2007 Posts: 68

*** Edited by montego: I split this post out from this thread here
http://montegoscripts.com/ftopict-409.html
*** and of edit.

I realize this conversation has spanned a couple of sites now, but wanted to pick your brain once more about another area of TON we have had to hardcode the shortened URL. The nukeSEO SB code... This is a little harder since you have URL's such as

Code:

http://www.diigo.com/post?url=http%3A%2F%2Fwww.rtsforce.com%2Fmodules.php%3Fname%3DNews%26file%3Darticle%26sid%3D16&title=DLC+-+The+Manhattan+Project+Pack

not sure I expect an easy answer here, but you have surprised me before Smile

the SB code

Code:

Site Admin/Owner Joined: Feb 12, 2005 Posts: 1294

My question on these is why do you want/need to "tap" these as they are supposed to be "hardcoded" out to the other social/share sites? Which links are internal to your site that you need/want tapped that you are not able to?

Newbie Joined: Sep 05, 2007 Posts: 68

my thought was, if you are using shortlinks why allow users to promote your site using the long url. depending on where/how it was shared you may get some seo benefit from SB, and search engines may end up following those links to untapped pages as well.

For the purposes of TON, when building the URL to be bookmarked, we are either using the goo.gl short url, the shortlink url if enabled, else the longurl.

Code:

//determine what links to use for SB
if (isset($googlapi) AND ($usegooglsb)) {
   $articleurl = $goourl;
   }elseif (defined('TNSL_USE_SHORTLINKS')){
   $articleurl = $nukeurl.'/article'.$sid.'.html';
   }else{
   $articleurl = $nukeurl.'/modules.php?name='.$module_name.'&file=article&sid='.$sid;
}
$articletitle = $title;
$socialbookmarkHTML = getBookmarkHTML( $articleurl, $articletitle, " ", "small");

TON also includes kguske's SB blocks which go about building links like so:

Code:

$_SERVER['FULL_URL'] = 'http';
$_SERVER['FULL_URL'] .= '://';
if($_SERVER['SERVER_PORT']!='80')
$_SERVER['FULL_URL'] .= $_SERVER['HTTP_HOST'].':'.$_SERVER['SERVER_PORT'].$_SERVER['SCRIPT_NAME'];
else
$_SERVER['FULL_URL'] .= $_SERVER['HTTP_HOST'].$_SERVER['SCRIPT_NAME'];
if($_SERVER['QUERY_STRING']>' ')
{
$_SERVER['FULL_URL'] .= '?'.$_SERVER['QUERY_STRING'];
}

Guess I'm looking for a shortlink aware method for building these urls... and my apologies, not sure why I posted in this thread.. could have sworn it was named something else..

Site Admin/Owner Joined: Feb 12, 2005 Posts: 1294

I'm a dope. You're talking about {MYNUKEURL}. Sorry.

I'll take a look. Smile

Site Admin/Owner Joined: Feb 12, 2005 Posts: 1294

I split out the thread...

And, am looking at the alternatives here.

Site Admin/Owner Joined: Feb 12, 2005 Posts: 1294

The problem with these links is they are embedded within other "links". In order to keep SL from messing up various things within JavaScript code, I have had to be more selective on what I tap. Therefore, this isn't going to be as easy as I would have hoped.

I can think of two options - that would have to come with a functional release, not a patch release - either:

1) Add a function to shortlinks.php that can be called from the nukeSEO SB code (or ANY other code anywhere) to "auto-tap" a link based upon a passed in URL string, or

2) Add another GTZ-PageTap.php like feature if enabled, would allow one to basically apply ANY preg_replace() of choice that would be executed at the very last step (i.e., after all other replacements have been made).

I actually like both of these options and may provide both in a 1.4.0 release.

Thoughts?

Newbie Joined: Sep 05, 2007 Posts: 68

Yes both sound excellent. For the time being we will continue to hard code the shorturl, but look forward to 1.4.0 Smile

Site Admin Joined: Jul 18, 2005 Posts: 383

All these various taps and associated problems (JS issues) are getting a bit complicated IMHO. We really need some sort of master URL handler Class (API) like the Zend/CI Frameworks use.
Maybe it's possible to write taps (I suppose they would be redirects technically) to htaccess or use the DB to store them.
It's something I have been meaning to look at for a while, along with caching whole pages (the rendered HTML being cached so no DB access is required) for Anon users.

Site Admin/Owner Joined: Feb 12, 2005 Posts: 1294

G-man, I've actually discussed some thoughts around leveraging Kguske's DH design as a potential SL replacement. For each module, he's already making available within the object some of the key data. I would like to extend this a bit... See this here which was carved out from another thread:

http://nukeseo.com/modules.php?name=Forums&file=viewtopic&t=499