NSNGD down-logo.gif

Posted: Tue Jul 12, 2011 1:45 pm

papamike wrote:

I think that's a good plan. Can you leave the transparent image that comes with Nuke in the package if I change the file extension from .GIF to .PNG ? Then it will show automatically as down-logo.png . The blue one that is default (now) with the new download mod is (well ...) Smile

This is the direction that I was coming from.

Now, I get your point and I knew you could just as easily have converted that image. I wanted to save you some time. But, at the time I thought you wanted to keep that (ugly) image.

Anyhow, all words put aside, I will work on a 'new' image. I will send you the first one, you look at it, and tell me "well change this or that" and together we will get it right.

Does that sound like a plan?

Site Admin/Owner Joined: Feb 12, 2005 Posts: 1294

Sounds good. I am confident your graphical skills are way beyond my capabilities.

Newbie Joined: Sep 05, 2007 Posts: 68

Not to complicate this further, but ideally I would like to see the logo (and other icons, graphics) declared via CSS

Code:

.down-logo {background-image:url('../../../modules/Downloads/images/logo.png'); width:282px;height:42px;}

<img class="down-logo" src="images/transparent.gif" />

Something like this would take advantage of RN's dynamic head functions and allow for theme specific overrides of the CSS file. Works similar to RN_MODULE_CSS, which is somewhat redundant since it also checks if the file exists.. RN_MODULE_CSS will not load a default file if the theme specific file is not found, which would be needed in this scenario.

Not sure if you are trying to keep some level of support for other *nuke versions, but stuck some (unfinished) logic in there for that as well..

Code:

$ThemeSel = get_theme();
define('NSNGD_MODULE_CSS','nsngd.css');
$modCssFile = 'themes/' . $ThemeSel . '/style/' . NSNGD_MODULE_CSS;
if (file_exists($modCssFile)) {
if (is_array($headCSS)) {
addCSSToHead($modCssFile, 'file');
}else{
// code for other nuke versions
}
}else{
if (is_array($headCSS)) {
addCSSToHead('modules/Downloads/' . NSNGD_MODULE_CSS, 'file');
}else{
// code for other nuke versions
}
}

So this would check for themes/CURRENT_THEME/style/nsngd.css and if not found, load modules/Downloads/nsngd.css

I suppose you could also load two css files and do your overrides via CSS

Code:

addCSSToHead('modules/Downloads/' . NSNGD_MODULE_CSS, 'file');
define('RN_MODULE_CSS', NSNGD_MODULE_CSS);

but i would prefer method #1, only loading one css file.

I have not had time to play with the new module yet Sad

But soon I hope.. Would be willing to help on a CSS setup for the icons if your interested. Might have to convert some of the code to use UL so we can depreciate things such as img align="middle"

Anyways, food for thought for a future version Wink

and this of course will not help the issue that started this thread... But in order for the theme architecture of RN to move forward, we are going to need to make *some changes that will require tweaks to existing themes...

Site Admin/Owner Joined: Feb 12, 2005 Posts: 1294

Spastic,

This is only a foundational release with very specific clean-ups to get to current 2.4.x RN standards, not beyond... yet. So, no worries, my plan is to morph all my offerings to newer HTML/CSS standards as well. In fact, I wish RN would move to HTML5/CSS3 (with some simple fall-backs - so important for the HUGE wave of mobile access coming as well). That's a little too cutting edge for something that is so widely distributed... But, even XHTML 1.0 Transitional was a huge step in the right direction (wish we had said "Strict").

Sure wish there was a module developer program with RN where we could get read-only access to the RN repository to stay on top of RN direction. Unfortunately, one has to wait until final release to know how things have changed.

Newbie Joined: Jan 30, 2009 Posts: 14 Location: NL

I like spasticdonkey's idea. It looks pretty good. I think it is the best option so it can load that icon really fast. Amazing! All modules, blocks, themes should call the way u point it spasticdonkey. Just take a look at www.phpnuke.org to see how phpnuke can change in one day.

Site Admin/Owner Joined: Feb 12, 2005 Posts: 1294

I don't see how changing from one image for a CSS image is going to make anything load any different (at least not in this case - yes, I agree, there are other cases where that would happen - sprites for one).

But, I completely agree with good sound well structure, meaningfully semantic, no presentation mark-up with good CSS2/3 to format will be much crisper.

Wow... I've never seen that site look so good in all the 6+ years I've been around *nuke.

Newbie Joined: Nov 26, 2007 Posts: 22

Other than they packaged the svn folders with 8.2 Wink

Site Admin/Owner Joined: Feb 12, 2005 Posts: 1294

Details...

Newbie Joined: Sep 05, 2007 Posts: 68

Thought I would take a moment to explain further why I suggested doing the logo like so:

Code:

.down-logo {background-image:url('../../../modules/Downloads/images/logo.png'); width:282px;height:42px;}

<img class="down-logo" src="images/transparent.gif" />

one of my priorities after the upcoming release of RN, is a style switching theme that also has support for media targeted css. This means a stylesheet for your printer, so in theory any page can be printed (and look good) without the need for additional scripts to format the page. Formatting the logo this way means I can use a different logo for the printable version. if needed.

Also, to make things hard on myself, the style switcher (which allows changing all aspects of the layout without a page refresh), will use both light and dark colored layouts. This means ideally the logo is defined via CSS so it can be switched dynamically if needed.

so this was a little self serving Rolling Eyes

although I will eventually be sharing the theme for free so I think many could benefit Smile

Site Admin/Owner Joined: Feb 12, 2005 Posts: 1294

spasticdonkey,

I can appreciate this. Let me give the approach more thought. While this isn't appropriate for a patch level, I may have to break my "rules"... Smile

I am also thinking that some folks will not want to even have an image, so this would also help with this as even the CSS can make this element "hidden".

One thought that popped into my mind is that there is also no consistency across modules in terms of look-and-feel. Wish there was a way to force this better, but it would take a RN Standard...

Newbie Joined: Sep 05, 2007 Posts: 68

I realize breaking your own rules isn't nearly as fun as breaking someone else's Razz

but seriously, don't feel like you need to do this in the immediate future if it breaks your plan. I have many theme improvements on the board and/or in discussion; and doubt I will have time to incorporate them all in the next release of RN.

In terms of consistency, are you referring to icons/graphics? general layouts? all of the above and more? lol

Site Admin/Owner Joined: Feb 12, 2005 Posts: 1294

spasticdonkey wrote:

In terms of consistency, are you referring to icons/graphics? general layouts? all of the above and more? lol

Sure.