| Author |
Message |
w2ibc
Newbie


Joined: Jul 14, 2009
Posts: 14
|
Posted:
Fri Mar 05, 2010 5:21 pm |
|
I been playing around with shortlinks in plat.
for the most part i have gotten everything to work as expected cept for the downloads blocks.
the EDL module taps fine. but the NSCenter_downloads and Advanced_Downloads will not tap correctly. and its related in how it outputs the download details.
correct (in the EDL module itself
downloaddetails-83-3990-Nuke-Plat_EDL_downloads_module_patch_3-4-2010.html#dldetails
incorrect in the 2 blocks
downloads.html&d_op=viewdownloaddetails&cid=83&lid=3990&title=Nuke-Plat%20EDL%20downloads%20module%20patch%203-4-2010#dldetails
i have went as far as in my GTB-block-NSCenter_Downloads.php pasting the entire GT-Downloads.php content in the file and i cant seem to get it to change the links correctly
something im missing maybe? |
| |
|
|
 |
montego
Site Admin/Owner


Joined: Feb 12, 2005
Posts: 1294
|
Posted:
Fri Mar 05, 2010 5:31 pm |
|
Looks like EDL is passing titles on the URL string! This is terrible! This is why I stripped ttitle out of Downloads and Web Links in RavenNuke(tm).
Fortunately, I think you can still get this to work, however, you need to make sure every one of these possible characters in your title strings (the encoded values in the URLs) are included in the pattern for the "title=" variable. |
_________________ “To err is human, but when the eraser wears out ahead of the pencil, you’re overdoing it.”
-- Josh Jenkins |
|
|
 |
w2ibc
Newbie


Joined: Jul 14, 2009
Posts: 14
|
Posted:
Fri Mar 05, 2010 6:27 pm |
|
well this is the downloads details line i have
modules.php\?name=Downloads&d_op=viewdownloaddetails&cid=([0-9]*)&lid=([0-9]*)&ttitle=([/:\-\'{}()\,\._&a-zA-Z0-9+= ]
which looks to me all there. (unless im overlooking something)
if i change the ttitle to title i get
downloaddetails-61-2019-Fall of the Republic.html#dldetails
which gives a 404
but its close to what EDL mod puts out with its
downloaddetails-61-2019-Fall_of_the_Republic.html#dldetails
missing the _ somewhere.... |
| |
|
|
 |
w2ibc
Newbie


Joined: Jul 14, 2009
Posts: 14
|
Posted:
Fri Mar 05, 2010 8:35 pm |
|
ok. after taking a break. and walking away for a bit thinking.
i used your idea and stripped the title call in the url. now i get
downloaddetails-47-3987-.html
in both blocks which works just fine.
i think I may just go though the module also and strip out the ttitle calls also.
but I got it working!
learned a bit to. |
| |
|
|
 |
montego
Site Admin/Owner


Joined: Feb 12, 2005
Posts: 1294
|
Posted:
Fri Mar 05, 2010 10:05 pm |
|
Yup, that is what it takes... taking breaks, coming back to it, learning along the way, etc... all good stuff. |
_________________ “To err is human, but when the eraser wears out ahead of the pencil, you’re overdoing it.”
-- Josh Jenkins |
|
|
 |
w2ibc
Newbie


Joined: Jul 14, 2009
Posts: 14
|
Posted:
Fri Mar 05, 2010 10:43 pm |
|
its prob going to be a headache once i dig into the edl module and strip out all the ttitle references in the urls
tbh prob should have went that route when the module was made, IMO
cat-lid is alot better then cat-lid-ttitle.
and from what i can tell seems to tap better with just cat-lid |
| |
|
|
 |
w2ibc
Newbie


Joined: Jul 14, 2009
Posts: 14
|
Posted:
Thu Mar 11, 2010 1:49 pm |
|
update.
I did like you done and stripped title from the url call.
now the blocks and module tap corectly and with the same tap url
both now tap /downloadsdetail-catid-lid.html
which works for me
thanks for the idea stripping title out of the urls |
| |
|
|
 |
montego
Site Admin/Owner


Joined: Feb 12, 2005
Posts: 1294
|
Posted:
Thu Mar 11, 2010 6:57 pm |
|
You are very welcome. Good job! |
_________________ “To err is human, but when the eraser wears out ahead of the pencil, you’re overdoing it.”
-- Josh Jenkins |
|
|
 |
|
|