Move nsngr_func.php inside module

Newbie Joined: Nov 26, 2007 Posts: 22

Since you are going to be working on this again I would like to see nsngr_func.php moved from includes/nsngr_func.php to modules/downloads/includes/nsngr_func.php

Of course that is just my opinion Smile

I am not sure about this but if it is the same as NukeProject it includes nsngr_func.php in mainfile.php. This should only be loaded in the blocks and module if needed, not every time.

Site Admin/Owner Joined: Feb 12, 2005 Posts: 1294

I agree. A simple include_once() in the block (if needed) and the module should do the trick. I had just read your email from Mantis on the NukeProject side and it does make sense.

Thanks!

Newbie Joined: Nov 26, 2007 Posts: 22

What do you think about also moving the language files into the module?

Site Admin/Owner Joined: Feb 12, 2005 Posts: 1294

BTW, since this is for NSN GR Downloads, I was thinking your original post was specific to that. Sorry, didn't look at the file name that closely... thought I saw nsngd. For the downloads module, they already are within the module.

The problem with NSN Groups, is that the administration side of things are for superusers and so things are split up a bit. But, I have no issues with moving from languages/nsngroups to /modules/Groups/languages as long as no-one else on the RN Team does. Probably a better discussion for Mantis or Raven's RN forums though.