Legal module issues

Newbie Joined: Dec 11, 2005 Posts: 19

Thought I would post this here since I found the issues with the Legal module for RN you worked on with DadaNuke.

First a couple of spelling corrections in the SQL file:

EDTIOR -> EDITOR
INDICENTAL - > INCIDENTAL

Next, since RN doesn't have a _cities table, attempts to update the Terms of Use content result in wiping out the default United States of America that is installed in the SQL. Further, there are no other choices in the list. Is the cities table something that's not included in the RN version of the download, or does the module assume this table exists (possibly from a post 7.6 version of Nuke)?

Spam Stopper - Comments Modules · Site Admin Joined: Jul 18, 2005 Posts: 307

Thats interesting.
Looks like the cities table was removed in 2.20.x. I remember some debate about it as it was only used by the Advertising module and seemed such a waste to have that huge table just to set one word which, might be why it was removed and just put in the Advertising blurb as editable plain text.
I'll have to remember this for when I eventually upgrade - thanks kguske!

Newbie Joined: Dec 11, 2005 Posts: 19

Yeah, I posted a message on DaDaNuke.org after I found the cities.sql in the 1.1 download of the Legal module.

Site Admin/Owner Joined: Feb 12, 2005 Posts: 946

Yeah, I forgot about that too. I will correct it within the RN SVN this week. I'll change it to go against the NS tables.

We had left the nuke_cities table within RN for upgrade purposes (i.e., we did not delete it), but we did remove it from the core install for new installs.

What is your "take" on the difference in the names of the countries between nuke_cities and the NS country table? I am not sure about this now.

Newbie Joined: Dec 11, 2005 Posts: 19

Haven't compared them. But I certainly like the idea of having a countries table (vs. getting unique countries from the cities tabe).

Site Admin/Owner Joined: Feb 12, 2005 Posts: 946

That is a fine idea as well. Will keep that in mind sir.